Whisk: add preset files #3424
Merged
Whisk: add preset files #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asn-d6
reviewed
Jun 14, 2023
presets/minimal/whisk.yaml
Outdated
| # Misc | ||
| # --------------------------------------------------------------- | ||
| # [customized] | ||
| CURDLEPROOFS_N_BLINDERS: 2 |
There was a problem hiding this comment.
Curdleproofs always requires 4 blinders, because of how the ZK protocol is designed.
There was a problem hiding this comment.
Noting that https://github.com/nalinbhardwaj/curdleproofs.pie is able to validate a generated proof with those parameters
|
This looks good now! However it seems like merging this PR will cause a good amount of test breakage? |
dapplion
added a commit
to dapplion/consensus-specs
that referenced
this pull request
Jun 20, 2023
* Add Whisk preset files * Use N=8 for minimal preset * Update spec_object var location
dapplion
added a commit
to dapplion/consensus-specs
that referenced
this pull request
Jun 22, 2023
* Add Whisk preset files * Use N=8 for minimal preset * Update spec_object var location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce shuffling sizes for minimal preset to have faster tests.
On offline discussions with @asn-d6 we noted that
CURDLEPROOFS_N_BLINDERS + WHISK_VALIDATORS_PER_SHUFFLEmust be a power of two, so for mainnet it's reduced from 128 to 124