Whisk: complete TODO items in fork logic #3427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asn-d6
reviewed
Jun 14, 2023
dapplion
commented
Jun 14, 2023
dapplion
added a commit
to dapplion/consensus-specs
that referenced
this pull request
Jun 20, 2023
* Complete TODO items in fork logic * Simpler underflow protection * Add saturating_sub
dapplion
added a commit
to dapplion/consensus-specs
that referenced
this pull request
Jun 22, 2023
* Complete TODO items in fork logic * Simpler underflow protection * Add saturating_sub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse
select_whisk_proposer_trackersandselect_whisk_candidate_trackersfor the fork transition initial selection of trackersAlso add missing properties from capella state initialization