Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wheel, pip, and setuptools with make install_test #3443

Merged
merged 2 commits into from Jul 14, 2023

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jul 6, 2023

In the process of debugging the CI failure in #3442. We're now updating to the latest versions of wheel, pip, and setuptools at the beginning of the make install_test command.

@hwwhww
Copy link
Contributor Author

hwwhww commented Jul 6, 2023

I realized that we may have to detect the pip upgrade and update the CI cache accordingly. Probably make more sense to pin the version in the CI configuration.

@hwwhww hwwhww marked this pull request as draft July 6, 2023 17:58
@djrtwo
Copy link
Contributor

djrtwo commented Jul 7, 2023

Pinning usually seems safer than upgrading to an arbitrary latest

@hwwhww hwwhww force-pushed the upgrade-installation-tools branch from 9150214 to 06dc897 Compare July 10, 2023 14:28
@hwwhww hwwhww marked this pull request as ready for review July 10, 2023 14:29
@hwwhww
Copy link
Contributor Author

hwwhww commented Jul 10, 2023

@djrtwo
To make it a bit more flexible, I changed it to only set minimum version requirements here.

@hwwhww hwwhww requested a review from djrtwo July 10, 2023 14:31
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hwwhww hwwhww merged commit a39abe3 into dev Jul 14, 2023
25 checks passed
@hwwhww hwwhww deleted the upgrade-installation-tools branch July 14, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants