-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More deneb tests #3457
More deneb tests #3457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! just a couple of nits
blob_kzg_commitments += commits | ||
|
||
for _ in range(non_blob_tx_count): | ||
txs.append(get_random_tx(rng=rng)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe should use rng
to shuffle the txs
list before applying to the el payload
@@ -259,7 +259,7 @@ def build_randomized_execution_payload(spec, state, rng): | |||
|
|||
num_transactions = rng.randint(0, 100) | |||
execution_payload.transactions = [ | |||
spec.Transaction(get_random_bytes_list(rng, rng.randint(0, 1000))) | |||
get_random_tx(rng) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helper should probably condition on is_post_bellatrix
(or whatever the appropriate helper is) to toss in some random blob TXs in Deneb and after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I thought about it, but it would need build_randomized_execution_payload
to return blob_kzg_commitments
, which is not well-compatible and clean with pre-deneb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
ready to merge when you are |
build_randomized_execution_payload
helper inrandom
testsblob_count