Whisk: don't mutate candidates during cooldown #3483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
force-pushed
the
whisk-cooldown
branch
from
795f28a
to
8eb449a
Compare
asn-d6
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During cooldown phase, validators do not provide a secret shuffle. However, the spec still mutates the trackers with public randnomess. This appears to be unnecessary, since latter steps of the protocol depend on the cumulative randnomness of randao provided by each proposer during the cooldown phase. Each participant should have the same influence in the shuffle outcome with this PR or without.
If there's no security benefit in mutating candidate trackers during cooldown, let's not do so to reduce some cycles during block processing and state hashing
CC: @asn-d6