Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename _INDEX generalized index constants to _GINDEX #3537

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

etan-status
Copy link
Contributor

To assist with readability, use _GINDEX suffix when referring to generalized index constants.

Does neither affect consensus, beacon-API nor builder API.

To assist with readability, use `_GINDEX` suffix when referring to
generalized index constants.

Does neither affect consensus, beacon-API nor builder API.
@etan-status etan-status mentioned this pull request Nov 1, 2023
2 tasks
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this

@hwwhww
Copy link
Contributor

hwwhww commented Nov 2, 2023

LGTM, but as we removed BLOB_KZG_COMMITMENTS_GINDEX from #3531, there is no need to include this PR in the next release. Let's hold it before the next release so we don't have to re-run testgen for it. :p

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

etan-status added a commit to status-im/nimbus-eth2 that referenced this pull request Nov 9, 2023
Rename constants for consistency with upcoming spec adjustment:

- ethereum/consensus-specs#3537
etan-status added a commit to status-im/nimbus-eth2 that referenced this pull request Nov 9, 2023
Rename constants for consistency with upcoming spec adjustment:

- ethereum/consensus-specs#3537
@hwwhww hwwhww merged commit 868a600 into ethereum:dev Jan 15, 2024
26 checks passed
@etan-status etan-status deleted the lc-gindexname branch January 15, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants