Use types for representing LC Merkle branches #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For better legibility and alignment with `ethereum/beacon-APIs`, use named types for the various Merkle branches used in the LC protocol. - https://github.com/ethereum/beacon-APIs/blob/v2.4.2/types/altair/light_client.yaml#L2-L22
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
hwwhww
reviewed
Jan 8, 2024
Comment on lines
44
to
45
| class ExecutionBranch(Vector[Bytes32, floorlog2(EXECUTION_PAYLOAD_INDEX)]): | ||
| pass |
There was a problem hiding this comment.
It is exactly what we convert the "custom types" into.
What do you think about just adding custom type ExecutionBranch: Vector[Bytes32, floorlog2(EXECUTION_PAYLOAD_INDEX)])?
hwwhww
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better legibility and alignment with
ethereum/beacon-APIs, use named types for the various Merkle branches used in the LC protocol.