Extract LC migration test helpers to light_client.py module
#3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helpers needed to migrate LC data across forks are generic enough to allow extraction from a specific test into the common `light_client.py` helper module. This way, it is possible to use them from future tests. Also complete the missing functions for `LightClientFinalityUpdate`, `LightClientOptimisticUpdate` and `LightClientHeader` in same style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helpers needed to migrate LC data across forks are generic enough to allow extraction from a specific test into the common
light_client.pyhelper module. This way, it is possible to use them from future tests.Also complete the missing functions for
LightClientFinalityUpdate,LightClientOptimisticUpdateandLightClientHeaderin same style.