Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing docker CI test and add docker tutorial #3573

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

parithosh
Copy link
Member

There's no reason to run this besides a sanity check, but running it against every PR is a bit overkill. We can add a filter such that the test runs only on PRs touching said file perhaps, maybe batching it with other docker related changes.

@hwwhww hwwhww changed the title Removing docker CI test Removing docker CI test and add tutorial Jan 10, 2024
@hwwhww hwwhww changed the title Removing docker CI test and add tutorial Removing docker CI test and add docker tutorial Jan 10, 2024
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some context: our CI jobs sometimes break due to the "Bind for 0.0.0.0:5000 failed: port is already allocated" errors. This PR removes the overkill test in CI.

lgtm!

docker/README.md Outdated Show resolved Hide resolved
@hwwhww hwwhww merged commit 3749caa into ethereum:dev Jan 10, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants