Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-7549: Enable EIP-7549 on CI #3640

Merged
merged 4 commits into from
Apr 3, 2024
Merged

EIP-7549: Enable EIP-7549 on CI #3640

merged 4 commits into from
Apr 3, 2024

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Apr 1, 2024

  • Fixed the testing helper so that EIP-7549 can be tested with our existing tests
  • Enable EIP-7549 on CI
  • Spec minor fixes
    • Note that we have to replace constants with *_EIP7549 ones.

@hwwhww hwwhww requested review from dapplion and mkalinin April 1, 2024 01:57
@hwwhww hwwhww changed the title Enable EIP-7549 on CI EIP-7549: Enable EIP-7549 on CI Apr 1, 2024
dapplion
dapplion approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you @hwwhww !

mkalinin
mkalinin approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR! I think we should work on a new aggregation strategy in testing infra (pack aggregates from different committees into a single on chain aggregate) in a separate PR and get this one merged!

@hwwhww hwwhww merged commit 025ebed into dev Apr 3, 2024
32 checks passed
@hwwhww hwwhww deleted the eip7549-tests branch April 3, 2024 12:57
@hwwhww hwwhww mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkalinin mkalinin mkalinin approved these changes

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hwwhww @mkalinin @dapplion