Various spec fixes for EIP-7251 #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
force-pushed
the
eip-7251-spec-fixes
branch
2 times, most recently
from
f0eb3b9
to
36b0c50
Compare
ralexstokes
force-pushed
the
eip-7251-spec-fixes
branch
from
36b0c50
to
8cf2fd5
Compare
Merged
dapplion
reviewed
Apr 9, 2024
| # If empty, will initialize a chain that has not yet gone through the Merge transition | ||
| state.latest_execution_payload_header = execution_payload_header | ||
|
|
||
| return state |
There was a problem hiding this comment.
@hwwhww are we still merging these? state bumps can be computed from the upgrade_to_* function
There was a problem hiding this comment.
they do serve distinct purposes
for testing, we will usually start at genesis, whereas at the fork boundary there is likely state we want to bring forward/translate from the old fork to the new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec fixes found while working on #3656.
Will merge here, and rebase that to just have test fixes.