Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixes and elaborates on comments for compute_kzg_proof_multi #3695

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

kevaundray
Copy link
Contributor

I fixed and fleshed out the comments a bit more for this function.

  • We were not computing the quotient polynomial in evaluation form. (We can't because it would cause a divide by zero error, with the current fft algorithm)

@kevaundray kevaundray changed the title Fixes and elboarates on comments for compute_kzg_proof_multi chore: Fixes and elboarates on comments for compute_kzg_proof_multi Apr 18, 2024
@jtraglia jtraglia changed the title chore: Fixes and elboarates on comments for compute_kzg_proof_multi chore: Fixes and elaborates on comments for compute_kzg_proof_multi Apr 18, 2024
kevaundray and others added 2 commits April 18, 2024 20:26
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
@hwwhww hwwhww added the EIP-7594 PeerDAS label Apr 19, 2024
@hwwhww hwwhww merged commit 9c04cf1 into ethereum:dev Apr 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants