Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use CELLS_PER_EXT_BLOB to compute the number of columns #3710

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Apr 22, 2024

Since we do not expose Field elements to the external API, we also do not expose the field element terminology. Instead, we use Cells and Blob, since Cells and Blobs are what we expose to the user

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

For rationale, we want to limit usage of "field elements" in the das-core spec.

@jtraglia jtraglia added the EIP-7594 PeerDAS label Apr 22, 2024
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a strict improvement over the status quo. LGTM.

@asn-d6 asn-d6 merged commit 4fceca2 into ethereum:dev Apr 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants