Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Pad column indices when calling verify_cell_kzg_proof_batch #3745

Merged
merged 4 commits into from
May 3, 2024
Merged

chore: Pad column indices when calling verify_cell_kzg_proof_batch #3745

merged 4 commits into from
May 3, 2024

Conversation

kevaundray
Copy link
Contributor

@kevaundray kevaundray commented May 3, 2024 •
edited

verify_cell_kzg_proof_batch expects the column indices array to be the same length as the row_indices array and the commitments array.

@kevaundray kevaundray changed the title chore: Pad column indices chore: Pad column indices when calling verify_cell_kzg_proof_batch May 3, 2024
@kevaundray kevaundray marked this pull request as ready for review May 3, 2024 15:50
@kevaundray kevaundray mentioned this pull request May 3, 2024
Closed
jtraglia
jtraglia approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 nice catch!

@asn-d6 asn-d6 merged commit 2abf4ce into ethereum:dev May 3, 2024
28 checks passed
@asn-d6 asn-d6 mentioned this pull request May 3, 2024
Open
@hwwhww hwwhww added the EIP-7594 PeerDAS label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

Assignees
No one assigned
Labels
EIP-7594 PeerDAS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevaundray @jtraglia @asn-d6 @hwwhww