Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update polynomial-commitments-sampling.md - Fix shift_polynomialcoeff #3792

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

b-wagn
Copy link
Contributor

@b-wagn b-wagn commented Jun 6, 2024

Fix inconsistency in function shift_polynomialcoeff.
The previous documentation claimed that g(x) = f(factor*x), but what is computed is g such that g(factor * x) = f(x). Now, I changed the implementation to match the documentation.

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit 76e2d52 into ethereum:dev Jun 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants