Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the source of the Vyper contract from the spec. #562

Merged
merged 3 commits into from
Feb 3, 2019
Merged

Removes the source of the Vyper contract from the spec. #562

merged 3 commits into from
Feb 3, 2019

Conversation

ralexstokes
Copy link
Member

Following up on this comment: #388 (review)

This change allows for easier maintenance of the code and the spec by
uncoupling them. Before any edit to either document resulted in having to
synchronize the other. By adding a reference to the canonical repo for the code
we avoid having to maintain a duplicate copy here.

Some things to consider:

  • do we like how the interface is specified here? should it just be dropped?
  • do we want a direct link to the Vyper source file? (right now just links to repo)

This change allows for easier maintenance of the code and the spec by
uncoupling them. Before any edit to either document resulted in having to
synchronize the other. By adding a reference to the canonical repo for the code
we avoid having to maintain a duplicate copy here.
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of minor comments

specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
@djrtwo djrtwo merged commit 3e2eb1c into ethereum:dev Feb 3, 2019
@ralexstokes ralexstokes deleted the remove-vyper-code branch February 4, 2019 01:00
@nisdas nisdas mentioned this pull request Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants