Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Do not merge yet) Reduce SSZ_CHUNK_SIZE to 32 #603

Closed
wants to merge 1 commit into from
Closed

(Do not merge yet) Reduce SSZ_CHUNK_SIZE to 32 #603

wants to merge 1 commit into from

Commits on Feb 11, 2019

  1. (Do not merge yet) Reduce SSZ_CHUNK_SIZE to 32 

    The intent of setting SSZ_CHUNK_SIZE = 128 is to reduce the cost of hashing. It is possible (to be confirmed once we have more concrete numbers from implementers) that the gains are limited and not worth the complexity of using a non-standard chunk size.

If the gains indeed are limited, this PR is aligned with the Eth2 goal "to minimize complexity, even at the cost of some losses in efficiency".
    @JustinDrake
    JustinDrake committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    224e5a0 View commit details
    Browse the repository at this point in the history