Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with vote_data in verify_slashable_attestation #635

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

jrhea
Copy link
Contributor

@jrhea jrhea commented Feb 15, 2019

update vote_date to slashable_attestation in verify_slashable_attestation.

@hwwhww hwwhww changed the base branch from master to dev February 15, 2019 04:53
@hwwhww
Copy link
Contributor

hwwhww commented Feb 15, 2019

Hey @jrhea, I updated to targeting dev branch, but the git log still looks not clean. Could you change to forking from dev branch, and then cherry-pick this commit? Thanks!

@JustinDrake JustinDrake self-requested a review February 15, 2019 13:48
@jrhea
Copy link
Contributor Author

jrhea commented Feb 15, 2019

@hwwhww oops. I forgot that dev was the default branch. 😋

replace vote_data with slashable_attestation in verify_slashable_attestation()
@jrhea jrhea reopened this Feb 15, 2019
@jrhea
Copy link
Contributor Author

jrhea commented Feb 15, 2019

@hwwhww and @JustinDrake the git log looks clean now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is vote_data in verify_slashable_attestation?
3 participants