Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unix time condition of an acceptable block #636

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Fix unix time condition of an acceptable block #636

merged 1 commit into from
Feb 15, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Feb 15, 2019 •
edited
Loading

Issue

While GENESIS_SLOT type/number debase is on-going, the current spec is incorrect when checking if block.slot is acceptable since block.slot is a number greater than 2 ** 63 now.

Solution

Change

  • The node's Unix time is greater than or equal to state.genesis_time + block.slot * SECONDS_PER_SLOT.

to

  • The node's Unix time is greater than or equal to state.genesis_time + (block.slot - GENESIS_SLOT) * SECONDS_PER_SLOT.

@JustinDrake JustinDrake merged commit 984eb79 into dev Feb 15, 2019
@djrtwo djrtwo deleted the hwwhww-patch-1 branch February 15, 2019 16:58
@terencechain terencechain mentioned this pull request Feb 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinDrake JustinDrake JustinDrake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwwhww @JustinDrake