Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deposit order todo #687

Merged
merged 2 commits into from
Feb 25, 2019
Merged

remove deposit order todo #687

merged 2 commits into from
Feb 25, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Feb 25, 2019 •
edited
Loading

What is the remaining TODO referencing?

[TODO: update the call to verify_merkle_branch below if it needs to change after we process deposits in order]

@djrtwo djrtwo requested review from hwwhww and JustinDrake and removed request for hwwhww February 25, 2019 14:59
@JustinDrake
Copy link
Collaborator

JustinDrake commented Feb 25, 2019 •
edited
Loading

Isn't this a much bigger change? For example we still have assert bls_verify( for the proof of possession.

@djrtwo
Copy link
Contributor Author

djrtwo commented Feb 25, 2019

ah, I remember. The change was in effect but a bad merge crushed it. I'll clean it up.

@djrtwo
Copy link
Contributor Author

djrtwo commented Feb 25, 2019

ready for review

@djrtwo djrtwo requested a review from hwwhww February 25, 2019 16:38
@djrtwo djrtwo merged commit da2ee5c into dev Feb 25, 2019
@hwwhww hwwhww mentioned this pull request Feb 25, 2019
Closed
@hwwhww hwwhww deleted the djrtwo-patch-1 branch March 29, 2019 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinDrake JustinDrake JustinDrake approved these changes

@hwwhww hwwhww Awaiting requested review from hwwhww

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djrtwo @JustinDrake