[WIP] Break up crosslink_committees_at_slot #707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
reviewed
Mar 1, 2019
terencechain
reviewed
Mar 1, 2019
| slot: Slot, | ||
| start_shard: Shard, | ||
| committees_per_epoch: int) -> List[Tuple[List[ValidatorIndex], Shard]]: | ||
| offset = slot % SLOTS_PER_EPOCH |
There was a problem hiding this comment.
should we add an assert to check shuffling_epoch out of bound condition?
assert get_previous_epoch(state) <= shuffling_epoch <= get_current_epoch(state)+1
| epochs_since_last_registry_update = current_epoch - state.validator_registry_update_epoch | ||
| if registry_change: | ||
| committees_per_epoch = get_next_epoch_committee_count(state) | ||
| seed = generate_seed(state, next_epoch) |
There was a problem hiding this comment.
we need to define next_epoch
| seed, | ||
| shuffling_epoch, | ||
| slot, | ||
| start_shard, |
There was a problem hiding this comment.
Suggested change
| start_shard, | |
| shuffling_start_shard, |
hwwhww
reviewed
Mar 1, 2019
| def get_crosslink_committees(state: BeaconState, | ||
| seed: Bytes32, | ||
| shuffling_epoch: Epoch, | ||
| slot: Slot, |
There was a problem hiding this comment.
Suggestion: move slot next to state to align with the order of the caller functions.
def get_crosslink_committees(state: BeaconState,
slot: Slot,
seed: Bytes32,
...| ) | ||
| for i in range(committees_per_slot) | ||
| ] | ||
| return get_next_epoch_committee_count(state, slot, registry_change) |
There was a problem hiding this comment.
Suggested change
| return get_next_epoch_committee_count(state, slot, registry_change) | |
| return get_next_epoch_committees_at_slot(state, slot, registry_change) |
|
Implemented here: prysmaticlabs/prysm#1771 |
|
Closing in favour of #808 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to "simplify"
get_crosslink_committees_at_slot.Broke it up into (maybe) more manageable functions. Not really convinced this helps much but throwing it up here while I think more
cc: @JustinDrake, @terenc3t