Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter slashing criteria #806

Merged
merged 7 commits into from
Mar 21, 2019
Merged

Stricter slashing criteria #806

merged 7 commits into from
Mar 21, 2019

Conversation

JustinDrake
Copy link
Collaborator

This is to prevent a spam/DoS attack where validators with zero balance get "slashed" but no validator loses any balance.

This is to prevent a spam/DoS attack where validators with zero balance get "slashed" but no validator loses any balance.
@JustinDrake JustinDrake changed the title Only slash active validators Stricter slashing criteria Mar 19, 2019
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added full set of proposer slashing tests that test this new condition

@djrtwo djrtwo merged commit 750383e into dev Mar 21, 2019
@djrtwo djrtwo deleted the JustinDrake-patch-19 branch March 21, 2019 23:10
sorpaas added a commit to paritytech/shasper that referenced this pull request May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants