Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hints of the new balance functions #830

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Fix type hints of the new balance functions #830

merged 1 commit into from
Mar 22, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Mar 22, 2019

Issue

Some typing hints are not explicit.

Solution

Fix typing hints and add docstrings.

@hwwhww hwwhww added the general:proofread spelling, grammar, accuracy label Mar 22, 2019
@hwwhww hwwhww merged commit 40aa82b into dev Mar 22, 2019
@hwwhww hwwhww deleted the hwwhww/balance_functions branch March 29, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinDrake JustinDrake JustinDrake approved these changes

Assignees
No one assigned
Labels
general:proofread spelling, grammar, accuracy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwwhww @JustinDrake