minor bug process_attester_slashings
#873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good to see more tests for this, the sanity check missed it 👍 |
|
I apparently skipped attester-slashing tests when I did the first pass on sanity tests 😬 |
hwwhww
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
The fix looks good to me!
A question:
Do we have to check that len(set(custody_bit_0_indices).intersaction(set(custody_bit_1_indices))) == 0 in verify_indexed_attestation or other check already covers this case?
I think it's rational that normally, AttesterSlashings are created by convert_to_indexed(state, Attestation) as your test case; but is it possible to create an IndexedAttestation with one index appears in both custody_bit_0_indices and custody_bit_1_indices after phase 1? If so, IMO we should make it clear and invalid in case of consensus error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor bug in
process_attester_slashingsin which it is using the incorrect (outdated)validator_indicesfield instead ofcustody_bit_0_indicesandcustody_bit_1_indices.Adds a number of attester slashing tests.
Thanks for finding this @protolambda