Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing typehint for convert_to_indexed #878

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Missing typehint for convert_to_indexed #878

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76893ca
Missing typehint for `convert_to_indexed`
JustinDrake Apr 3, 2019
6ca3c64
Update 0_beacon-chain.md
JustinDrake Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions specs/core/0_beacon-chain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,9 +1160,9 @@ def verify_bitfield(bitfield: bytes, committee_size: int) -> bool:
### `convert_to_indexed`

```python
def convert_to_indexed(state: BeaconState, attestation: Attestation):
def convert_to_indexed(state: BeaconState, attestation: Attestation) -> IndexedAttestation:
"""
Convert an attestation to (almost) indexed-verifiable form
Convert ``attestation`` to (almost) indexed-verifiable form.
"""
attesting_indices = get_attestation_participants(state, attestation.data, attestation.aggregation_bitfield)
custody_bit_1_indices = get_attestation_participants(state, attestation.data, attestation.custody_bitfield)
Expand All @@ -1172,7 +1172,7 @@ def convert_to_indexed(state: BeaconState, attestation: Attestation):
custody_bit_0_indices=custody_bit_0_indices,
custody_bit_1_indices=custody_bit_1_indices,
data=attestation.data,
aggregate_signature=attestation.aggregate_signature
aggregate_signature=attestation.aggregate_signature,
)
```

Expand Down