Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 quick fixes for the test_formats readme (1 dead link, 1 typo) #897

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

JSON
Copy link
Contributor

@JSON JSON commented Apr 11, 2019

Link: (https://github.com/ethereum/eth2.0-specs/blob/dev/specs/test_formats/README.md#yaml-suite) in the ToC is now a dead link. The live link for that section is (https://github.com/ethereum/eth2.0-specs/blob/dev/specs/test_formats/README.md#test-suite).

Typo: Extra asterisk after "consumer"* removed so that it can be italicized as intended like "producer"
Note: (asterisk)(asterisk)(word)(asterisk) renders as (italicized word)(asterisk) here, but on the spec itself it just shows up as (asterisk)(asterisk)(word)(asterisk). I don't think (italicized word)(asterisk) was the intention either since there is no corresponding footnote below.

@JustinDrake JustinDrake merged commit 5e8172a into ethereum:dev Apr 12, 2019
@JSON JSON deleted the patch-4 branch April 14, 2019 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants