Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link standardization on 0_beacon-chain-validator.md #909

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

JSON
Copy link
Contributor

@JSON JSON commented Apr 12, 2019

Link standardization to keep you on the branch you are on.

One edit that may need closer review: On line 402, (../core/0_beacon-chain.md#proposalsigneddata) was linked to. I changed it to (../core/0_beacon-chain.md#beaconblock) since #proposalsigneddata is now a dead link/tag. #769 suggests that BeaconBlock is its replacement, so I’m guessing that’s the intended destination.

One remaining question: On line 103, (https://github.com/ethereum/eth2.0-specs/blob/master/specs/core/0_beacon-chain.md#depositinput) is linked to. However the tag #depositinput is now dead on the ‘dev’ branch, so it just takes you to the top of the main beacon chain page. I can’t tell where #depositinput was intended to direct to, so I left it as is.

@JustinDrake JustinDrake merged commit 0b6d6f2 into ethereum:dev Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants