Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leftover DepositInput → DepositData #912

Merged
merged 2 commits into from
Apr 13, 2019
Merged

Leftover DepositInput → DepositData #912

merged 2 commits into from
Apr 13, 2019

Conversation

JSON
Copy link
Contributor

@JSON JSON commented Apr 13, 2019

Due to #780:
DepositInput → DepositData
deposit_input → deposit_data

For line 107, serialize(deposit_input) is changed to serialize(deposit.data) since . rather than _ is used here: https://github.com/ethereum/eth2.0-specs/blob/dev/specs/core/0_beacon-chain.md#deposits Please correct if wrong

@djrtwo
Copy link
Contributor

djrtwo commented Apr 13, 2019

Deposit is a higher level wrapper created by the deposit contract. The validator sends the serialized object DepositData (named deposit_data here) as the payload of the eth1 tx so it should be serialize(deposit_data). I'll clean it up

djrtwo
djrtwo approved these changes Apr 13, 2019
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@djrtwo djrtwo merged commit 5d55486 into ethereum:dev Apr 13, 2019
@JSON
Copy link
Contributor Author

JSON commented Apr 13, 2019

thank you!

@JSON JSON deleted the patch-9 branch April 14, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JSON @djrtwo