pytests use configuration system #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I made another PR on it: #981 so that we can organize all dependencies in |
protolambda
force-pushed
the
pytest-use-config
branch
from
eb6007e
to
02e6d5b
Compare
|
rebased on dev, PR should run cleanly now. Hope this resolves the strange local-execution issues @hwwhww was experiencing. |
|
It works now! Straaange. |
1. Move .venv to TEST_LIBS_DIR/ 2. Install `config_helpers` separately
djrtwo
force-pushed
the
pytest-use-config
branch
from
16d6014
to
b1874dc
Compare
These failed tests had to do with the low number of validators (100) compared to the slots_per_epoch. When generating attestations, I am often assuming there is at least 2 validators per committee. I changed |
djrtwo
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements.txtin two: one for normal use (whatever that may be), one for running tests (has the normalrequirements.txtas-rline to ensure you don't miss the dependencies)Also: I fixed a minor testing bug that was uncovered because of a small constant change: minimal config has a shorter eth1-data voting period. The new winning vote set the eth1-deposit count to 0, and it resulted in a negative expected-deposit-count. Default test-blocks are prepared with a vote for whatever deposit count the state says it is at.
Maybe we should add a voting requirement to the spec itself, so that you can't make the eth1-data deposit counter lower than the deposit index in the state.
Note: I don't believe anyone has actively been maintaining the test-correctness for non-
minimal_config. Currently, when running tests against the mainnet config (slower), some of them fail. I identified a few root causes:assert verify_attestation(...)fails for some reason, acommitteefor some shard was not found, and committee size <-> bitfield size is off.