Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

libp2p libdevcrypto should not depends on test or have any link into test folder #2973

Closed
smartbitcoin opened this issue Sep 15, 2015 · 1 comment
Closed

libp2p libdevcrypto should not depends on test or have any link into test folder #2973

smartbitcoin opened this issue Sep 15, 2015 · 1 comment

Comments

@smartbitcoin
Copy link
Contributor

test/JsonSpiritHeaders.h need move into a common place since it was hard included in libp2p and libdevcrypto etc.

this is a bad coding practice to make a library build depends on head file in test directory.
@ghost ghost mentioned this issue Sep 30, 2015
Closed
@ghost
Copy link

ghost commented Sep 30, 2015

Issue moved to webthree-umbrella.

@ghost ghost closed this as completed Sep 30, 2015
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smartbitcoin