This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Include INVALID instruction #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4055 +/- ##
===========================================
- Coverage 65.72% 65.64% -0.09%
===========================================
Files 307 307
Lines 22733 22733
===========================================
- Hits 14941 14922 -19
- Misses 7792 7811 +19
|
axic
force-pushed
the
invalid-instruction
branch
from
1b42efa
to
d041859
Compare
axic
commented
Apr 24, 2017
| { Instruction::SUICIDE, { "SUICIDE", 0, 1, 0, true, Tier::Special } }, | ||
|
|
||
| // these are generated by the interpreter - should never be in user code | ||
| { Instruction::PUSHC, { "PUSHC", 2, 0 , 1, false, Tier::VeryLow } }, | ||
| { Instruction::JUMPC, { "JUMPC", 0, 1, 0, true, Tier::Mid } }, | ||
| { Instruction::JUMPCI, { "JUMPCI", 0, 1, 0, true, Tier::High } }, | ||
| { Instruction::STOP, { "BAD", 0, 0, 0, true, Tier::Zero } }, |
There was a problem hiding this comment.
This seems to have been broken all the time. (STOP vs BAD)
There was a problem hiding this comment.
Oh - misread, but yes, broken all along.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4053.