This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Disable framing in devp2p for all protocol versions #4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
suggested changes
Oct 11, 2017
libp2p/Session.h
Outdated
| @@ -90,7 +90,7 @@ class SessionFace | |||
| class Session: public SessionFace, public std::enable_shared_from_this<SessionFace> | |||
| { | |||
| public: | |||
| static bool isFramingAllowedForVersion(unsigned _version) { return _version > 4; } | |||
| static bool isFramingAllowedForVersion(unsigned _version) { return false; } | |||
There was a problem hiding this comment.
You have to ignore the argument. (void)_version.
|
Let's ship this change. Later we should probably drop this feature. |
|
CC @gluk256. |
gumb0
force-pushed
the
disable-devp2p-framing
branch
from
541e5bc
to
d578805
Compare
chfast
approved these changes
Oct 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was preventing from succesfully communicating with devp2p v5 geth nodes