discv5: NAT hole punching wire protocol #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
changed the title
fjl
changed the title
fjl
reviewed
Mar 30, 2023
emhane
force-pushed
the
nat-hole-punch-wire
branch
from
c3578bb
to
1a9d5a3
Compare
emhane
force-pushed
the
nat-hole-punch-wire
branch
from
40cd01f
to
d53dade
Compare
It's confusing to have both a 'notification message' and a 'notification packet' because the packet type is also used for response messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fjl and I made this fantastically optimised NAT hole punch protocol! @fjl I can't add you as a reviewer after creating the PR. nat_msg
Implemented and tested https://github.com/emhane/nat_hole_punch/tree/standardise-nat-hole-punch