-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discv5: additional text around NAT hole punching #231
base: discv5-v5.2
Are you sure you want to change the base?
Conversation
Co-authored-by: Felix Lange <fjl@twurst.com>
Now, it is ready for review. If you may @fjl . |
Right now, it isn't super clear from this text what the implementation requirements are. The text has both descriptions of implementation features and rationale-type content, where you explain 'common situations' and their outcomes. Please add a section that clearly states the logic that implementations should apply. Specifically, please describe separately the rules for NAT traversal initiator, relay, and recipient. |
Ok, done, let me know what you think. |
Theory around the actual hole punching: keeping a hole punched, how a node discovers if it is behind a NAT and some on how the handling of holes maintains properties held by the p2p network.