馃毃 fix linting warning (rule B019) #230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The codebase currently use the
lru_cache
decorator in theNodeVisitor
andABIRegistry
classes over methods. Theflake8-bugbear
linter reported aB019
warning, indicating potential memory leaks in class methods. Thelru_cache
decorator retain instance references, impeding garbage collection and potentially leading to memory-related issues.Related to Issue #218
Closes #218
How was it fixed?
We don't have to replace
lru_cache
with something else for solve linter warning. This problem can be solved in the following way: we stopped using decorators directly over methods. Instead we apply the decorator function when initializing a class instance.Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture