Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic array support #95

Merged
merged 10 commits into from
Aug 28, 2018
Merged

Dynamic array support #95

merged 10 commits into from
Aug 28, 2018

Conversation

carver
Copy link
Collaborator

@carver carver commented Aug 22, 2018

What was wrong?

Closes #94

How was it fixed?

Backported #90 and #92 sequentially (plus some in-commit patches to make it v1-compatible)

Cute Animal Picture

Cute animal picture

@carver carver requested a review from davesque August 22, 2018 21:23
@carver
Copy link
Collaborator Author

carver commented Aug 22, 2018

@davesque Have you seen this ~"examples too slow" error from hypothesis on pypy before? I'm sure I can dig in and figure it out, just curious if you had a quick fix handy.

@pipermerriam
Copy link
Member

@carver probably worth just creating an issue and adding the too_slow to the ignored health checks.

@carver
Copy link
Collaborator Author

carver commented Aug 28, 2018

Ok, ready for review, then.

@davesque
Copy link
Contributor

@carver My "quick fix" lately has just been to re-run the failed job until is passes :). I believe the failing tests are the ones which do property testing to check coder class behavior. They should actually be deleted since they aren't that useful. That's the real fix.

@davesque
Copy link
Contributor

@carver Actually, I was wrong. I think the issue was being caused by a recursive strategy that was generating too many leaves. I made a one-line PR for that issue specifically. I think you can revert the fix you added to this PR.

@carver
Copy link
Collaborator Author

carver commented Aug 28, 2018

Cool, I removed the slow test exception. I'll wait to merge until you review, @davesque

Copy link
Contributor

@davesque davesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go, Jason.

@carver carver merged commit 8972f08 into ethereum:stable/1.x Aug 28, 2018
@carver carver deleted the dynamic-arrays-v1 branch August 28, 2018 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants