-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic array support #95
Conversation
@davesque Have you seen this ~"examples too slow" error from hypothesis on pypy before? I'm sure I can dig in and figure it out, just curious if you had a quick fix handy. |
@carver probably worth just creating an issue and adding the |
Ok, ready for review, then. |
@carver My "quick fix" lately has just been to re-run the failed job until is passes :). I believe the failing tests are the ones which do property testing to check coder class behavior. They should actually be deleted since they aren't that useful. That's the real fix. |
@carver Actually, I was wrong. I think the issue was being caused by a recursive strategy that was generating too many leaves. I made a one-line PR for that issue specifically. I think you can revert the fix you added to this PR. |
f0bf403
to
c15ca57
Compare
Cool, I removed the slow test exception. I'll wait to merge until you review, @davesque |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go, Jason.
What was wrong?
Closes #94
How was it fixed?
Backported #90 and #92 sequentially (plus some in-commit patches to make it v1-compatible)
Cute Animal Picture