Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace is_valid_abi_type with ABI's is_encodable_type method #59

Closed
Bhargavasomu opened this issue Apr 1, 2019 · 2 comments
Closed

Replace is_valid_abi_type with ABI's is_encodable_type method #59

Bhargavasomu opened this issue Apr 1, 2019 · 2 comments

Comments

@Bhargavasomu
Copy link
Contributor

What was wrong?

Currently eth-account is still supporting python 3.5. But to replace utils method is_valid_abi_type with ABI's method is_encodable_type, it is possible only when the support of python 3.5 is removed by eth-account, because eth-abi currently doesn't support python 3.5

How can it be fixed?

Replace the function, when the support for python 3.5 is dropped in eth-account.
@Bhargavasomu
Copy link
Contributor Author

Further details related to this issue can be found here

@Bhargavasomu Bhargavasomu mentioned this issue Apr 1, 2019
Merged
@fubuloubu fubuloubu mentioned this issue May 31, 2019
Merged
@carver
Copy link
Contributor

carver commented Jun 6, 2019

Closed by #67

@carver carver closed this as completed Jun 6, 2019
pacrob pushed a commit to pacrob/eth-account that referenced this issue Apr 26, 2023
@carver
Merge pull request ethereum#59 from ethereum/pydocstyle-explain
c4f23a4 
Show full explanation for pydocstyle failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carver @Bhargavasomu