Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version limits for bitarray dependency #161

Closed
wants to merge 2 commits into from

Conversation

oberstet
Copy link

fixes #160

@carver
Copy link
Contributor

carver commented May 20, 2022

Bumping this is a breaking change by our semver rules. If we left the lower limit and increase only the upper limit, then I expect it to be fine. Already installed copies should keep working fine, and newly installed copies will grab the latest available.

@carver
Copy link
Contributor

carver commented May 20, 2022

Ah, looks like this is already covered by #159 -- although I think you're right that the upper limit should just be v3

I'm going to close it as a duplicate, though

@carver carver closed this May 20, 2022
@oberstet
Copy link
Author

ok, sounds good! thanks!

Bumping this is a breaking change by our semver rules. If we left the lower limit and increase only the upper limit

fwiw, in general, any upper limit is a pain. I have spent quite some hours because of a diamond shaped dependency graph with the same library being a dependency via two intermediary nodes, merging in a single app as tree root. if the dependency is required in different upper versions in the intermediary nodes in the dependency graph, pip will usually go into infinite looping to figure out a resolved tree. The solution then is to manually figure out a working version, pin that version in requirements of the app, so that pip will be forced to use that version. even figuring out that pip behavior took me many hours. IOW: pls try to avoid any upper limits;) my 2cts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.11
2 participants