Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more useful ENR.__str__ implementation #14

Merged

Conversation

pipermerriam
Copy link
Member

What was wrong?

The output of str(enr) only gave the base64 encoded representation which tells you very little about the record.

How was it fixed?

Added an ENR.__str__ implementation which includes all of the ENR fields in human readable representations.

Cute Animal Picture

unlikely-animal-friendships-4

Copy link

@gsalgado gsalgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pipermerriam pipermerriam merged commit 2da4242 into ethereum:master Oct 22, 2020
@pipermerriam pipermerriam deleted the piper/add-str-implementation-to-ENR branch October 22, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants