Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isinstance checks don't work on data types #26

Closed
pipermerriam opened this issue Dec 19, 2017 · 0 comments · Fixed by #36
Closed

isinstance checks don't work on data types #26

pipermerriam opened this issue Dec 19, 2017 · 0 comments · Fixed by #36

Comments

@pipermerriam
Copy link
Member

pipermerriam commented Dec 19, 2017

What was wrong?

This code returns that the pk is not an instance of PrivateKey. It should return True

In [141]: from eth_keys import keys

In [142]: pk = keys.PrivateKey(b'\x01' * 32)

In [143]: isinstance(pk, keys.PrivateKey)
Out[143]: False

How can it be fixed?

Need to un-tangle the dynamic class generation that occurs in the backends in such a way that we still get a friendly backend API.

pacrob pushed a commit to pacrob/eth-keys that referenced this issue Dec 20, 2023
…ve-pypy-markdown-support

switch to native pypy markdown support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant