Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api cleanup #16

Merged
merged 2 commits into from
Sep 25, 2017
Merged

api cleanup #16

merged 2 commits into from
Sep 25, 2017

Conversation

pipermerriam
Copy link
Member

What was wrong?

  • The KeyAPI object was awkward for the common use case, requiring you instantiate it everytime you wanted to do pk operations.
  • The Signature.recover_* api names were misleading.
  • The PrivateKey.sign api name wasn't as explicit as I would like.
  • The PublicKey.recover_ api names were misleading.

How was it fixed?

  • There is now a KeyAPI instance that can be imported from eth_keys.keys which will lazily use whatever backend has been configured via environment variable.
  • Signature.recover_public_key_from_msg and Signature.recover_public_key_from_msg_hash
  • PrivateKey.sign_msg
  • PublicKey.recover_from_msg and PublicKey.recover_from_msg_hash

Cute Animal Picture

baby_red_panda

@pipermerriam pipermerriam merged commit cac77fb into master Sep 25, 2017
@pipermerriam pipermerriam deleted the piper/change-obj-api-names branch September 25, 2017 17:46
@pipermerriam pipermerriam mentioned this pull request Sep 25, 2017
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant