let eth-hash manage the backend versioning #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, make it available in local development env through requirements-dev.txt
carver
force-pushed
the
carver/eth-hash-backend
branch
from
6b97f0b
to
4f4f7f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The testing configs were hard-coding the pycryptodome versioning. If/when eth-hash updates to work with a different pycryptodome major version, then this testing config would break.
How was it fixed?
Use the eth-hash extra to define the pycryptodome version. Intentionally don't pin the eth-hash version, so that eth-utils specifies it.
Cute Animal Picture