-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated import #65
Remove deprecated import #65
Conversation
@njgheorghita ping for review |
Oh, wait a minute, this is causing a sea of failed tests... |
Alright, it's ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! It's nice to see your deprecation warning pay off 😅
@pipermerriam I don't have merge rights in this repo |
@pipermerriam Could you merge this for me (or grant me merge rights) |
* Tweaks to release process * Drop python 3.6
toxinidir won't mean anything in a Makefile
What was wrong?
We are importing from a deprecated library causing warnings in downstream projects such as Trinity.
How was it fixed?
Add
eth-typing
dependency and useChecksumAddress
from there.Cute Animal Picture