Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated import #65

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Remove deprecated import #65

merged 2 commits into from
Jan 8, 2020

Conversation

cburgdorf
Copy link
Contributor

What was wrong?

We are importing from a deprecated library causing warnings in downstream projects such as Trinity.

/home/cburgdorf/Documents/hacking/ef/trinity/venv/lib/python3.7/site-packages/eth_keys/datatypes.py:28: DeprecationWarning: The eth_utils.typing module will be deprecated in favor of eth-typing in the next major version bump.
  from eth_utils.typing import (

How was it fixed?

Add eth-typing dependency and use ChecksumAddress from there.

Cute Animal Picture

Cute animal picture

@cburgdorf
Copy link
Contributor Author

@njgheorghita ping for review

@cburgdorf
Copy link
Contributor Author

Oh, wait a minute, this is causing a sea of failed tests...

@cburgdorf
Copy link
Contributor Author

Alright, it's ready for review now.

@cburgdorf cburgdorf mentioned this pull request Dec 20, 2019
Closed
6 tasks
njgheorghita
njgheorghita approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@njgheorghita njgheorghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's nice to see your deprecation warning pay off 😅

@cburgdorf
Copy link
Contributor Author

@pipermerriam I don't have merge rights in this repo

@cburgdorf
Copy link
Contributor Author

@pipermerriam Could you merge this for me (or grant me merge rights)

@pipermerriam pipermerriam merged commit a181917 into ethereum:master Jan 8, 2020
pacrob pushed a commit to pacrob/eth-keys that referenced this pull request Dec 20, 2023
@kclowes
Misc Updates (ethereum#65)
99af2f4 
* Tweaks to release process

* Drop python 3.6
pacrob pushed a commit to pacrob/eth-keys that referenced this pull request Dec 20, 2023
@carver
Fix a copy-paste mistake from ethereum#65
4bd0240 
toxinidir won't mean anything in a Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pipermerriam pipermerriam pipermerriam approved these changes

@njgheorghita njgheorghita njgheorghita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cburgdorf @pipermerriam @njgheorghita