Expose ValidationError for backwards compatibility #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
approved these changes
Apr 22, 2020
| ) | ||
|
|
||
| from eth_keys import KeyAPI | ||
| from eth_keys.backends import NativeECCBackend | ||
| from eth_keys.exceptions import ValidationError |
There was a problem hiding this comment.
Maybe better to have these import directly from eth_utils?
There was a problem hiding this comment.
👍 I was using it to verify that the eth_keys exception import still works. But, better to do that explicitly with a new test, instead.
carver
force-pushed
the
backward-compatible-ValidationError
branch
from
a637232
to
4fa966c
Compare
pacrob
pushed a commit
to pacrob/eth-keys
that referenced
this pull request
Dec 20, 2023
- It is not recommended to invoke ``setup.py`` directly, instead opting for ``python -m build`` for the commands in this commit (see: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html) - Add newsfragment for ethereum#70
pacrob
pushed a commit
to pacrob/eth-keys
that referenced
this pull request
Dec 20, 2023
Do not invoke `setup.py` directly; minor refactor + cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
#68 (comment)
How was it fixed?
Re-add
ValidationErrorateth_keys.exceptions.ValidationError, but using the eth-utils version.Cute Animal Picture