Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add py.typed file, move misplaced newsfrag, correct py version pins for typing-extensions, bump hexbytes to >=1.0.0 #21

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

pacrob
Copy link
Collaborator

@pacrob pacrob commented Mar 1, 2024

What was wrong?

A couple minor things needing fixing. Also, breaking bump of hexbytes dependency to >=1.0.0

Todo:

  • Clean up commit history

  • Add or update documentation related to these changes

  • Add entry to the release notes

Cute Animal Picture

image

@pacrob pacrob changed the title add py.typed file, move misplaced newsfrag, correct py version pins for typing-extensions add py.typed file, move misplaced newsfrag, correct py version pins for typing-extensions, bump hexbytes to >=1.0.0 Mar 1, 2024
@pacrob pacrob requested review from reedsa, fselmo and kclowes March 1, 2024 17:02
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

Edit: The code looks good to me, but what the heck is up with those snakes??

@pacrob pacrob merged commit 3c5b475 into ethereum:main Mar 4, 2024
37 checks passed
@pacrob pacrob deleted the cleanup branch March 4, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants