Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields to transaction receipt #228

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

fselmo
Copy link
Contributor

@fselmo fselmo commented Dec 26, 2021

What was wrong?

  • Receipts are missing the to and from keys as well as some others. We will also be able to test this via web3 here.

How was it fixed?

  • Add to, from, and status to receipts.
  • Add tests

To-Do:

Cute Animal Picture

Cute animal picture

@fselmo fselmo force-pushed the add_to_and_from_to_receipts branch 2 times, most recently from b66bbf1 to 6499795 Compare December 26, 2021 21:34
Copy link
Contributor

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@@ -173,17 +173,26 @@ def _validate_outbound_access_list(access_list):
)


def validate_status(value):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change 😎

@fselmo fselmo merged commit 14cddc2 into ethereum:master Jan 3, 2022
@fselmo fselmo deleted the add_to_and_from_to_receipts branch January 25, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants