Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest py-evm #84

Merged

Conversation

pipermerriam
Copy link
Member

@pipermerriam pipermerriam commented Apr 25, 2018

Upstream changes to py-evm needed to be accounted for.

@pipermerriam
Copy link
Member Author

Will require upgrade to py-evm

ethereum/py-evm#581

before this can really be merged (which will also require local support for latest py-evm to be resolved (currently has a fundamentally broken issue outlined here: ethereum/py-evm#579

@pipermerriam pipermerriam changed the title test against rlp v1.0.0 Update to latest py-evm May 1, 2018
@pipermerriam pipermerriam requested a review from carver May 1, 2018 19:51
@@ -208,20 +208,10 @@ def _execute_and_revert_transaction(chain, transaction, block_number="latest"):

def _get_vm_for_block_number(chain, block_number, mutable=False):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe delete mutable kwarg?

setup.py Outdated
'test': [
'pytest>=3.2.1,<4.0.0',
'pytest-xdist>=1.22.2,<2',
'flake8==3.0.4',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably drop this flake8

@pipermerriam pipermerriam merged commit 883b0b9 into ethereum:master May 1, 2018
@pipermerriam pipermerriam deleted the piper/test-with-rlp-v1.0.0 branch May 1, 2018 21:44
pacrob pushed a commit to pacrob/eth-tester that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants