Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to release tarball (in PyPI) #8

Closed
jluttine opened this issue Sep 11, 2018 · 2 comments · Fixed by #46
Closed

Add tests to release tarball (in PyPI) #8

jluttine opened this issue Sep 11, 2018 · 2 comments · Fixed by #46

Comments

@jluttine
Copy link

Could you include tests in the source tarball in PyPI? I think it's good practice:

This way one can run the tests after installing the package. Also, I'm currently packaging this for a Linux distro, and it would be really helpful to be able to run the tests as a part of the automatic package building process while using PyPI for the release tarballs.

(See also ethereum/eth-utils#130)

@lemenkov
Copy link

Hello!
Is there any progress here? It would be really good if you add tests to PyPi tarball as well.

@kclowes
Copy link
Contributor

kclowes commented Jun 8, 2023

This issue was lost to the sands of time, and I just saw it again going through old issues. I don't see a problem including tests. Added PR #46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants