New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wonky calculation in WITHDRAWAL_PERIOD #20

Closed
benjaminion opened this Issue Oct 2, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@benjaminion
Copy link
Contributor

benjaminion commented Oct 2, 2018

WITHDRAWAL_PERIOD - number of slots between a validator exit and the validator slot being withdrawable. Currently set to 2**19 = 524288 slots, or 2**23 seconds ~= 97 days.

2**19 slots is 2**22 seconds ~= 48.5 days.

@djrtwo

This comment has been minimized.

Copy link
Contributor

djrtwo commented Oct 2, 2018

Yup, you're right. Getting this fix up shortly

@benjaminion

This comment has been minimized.

Copy link
Contributor Author

benjaminion commented Oct 2, 2018

Vitalik has since changed SLOT_DURATION from 8 to 16 seconds, so this calculation is now correct.

@djrtwo

This comment has been minimized.

Copy link
Contributor

djrtwo commented Oct 2, 2018

Indeed. I'm still gunning for 8 seconds!
Some of these constants won't get 100% locked down until some serious client testing.

Closing

@djrtwo djrtwo closed this Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment