Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wonky calculation in WITHDRAWAL_PERIOD #20

Closed
benjaminion opened this issue Oct 2, 2018 · 3 comments
Closed

Wonky calculation in WITHDRAWAL_PERIOD #20

benjaminion opened this issue Oct 2, 2018 · 3 comments

Comments

@benjaminion
Copy link
Contributor

WITHDRAWAL_PERIOD - number of slots between a validator exit and the validator slot being withdrawable. Currently set to 2**19 = 524288 slots, or 2**23 seconds ~= 97 days.

2**19 slots is 2**22 seconds ~= 48.5 days.
@djrtwo
Copy link
Contributor

djrtwo commented Oct 2, 2018

Yup, you're right. Getting this fix up shortly

@benjaminion
Copy link
Contributor Author

Vitalik has since changed SLOT_DURATION from 8 to 16 seconds, so this calculation is now correct.

@djrtwo
Copy link
Contributor

djrtwo commented Oct 2, 2018

Indeed. I'm still gunning for 8 seconds!
Some of these constants won't get 100% locked down until some serious client testing.

Closing

@djrtwo djrtwo closed this as completed Oct 2, 2018
hwwhww pushed a commit that referenced this issue Jul 23, 2020
@MrChico
Add unit test and fuzzing against Vyper (#20)
6c07707
hwwhww pushed a commit that referenced this issue Jul 23, 2020
@MrChico
Add unit test and fuzzing against Vyper (#20)
fea839f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djrtwo @benjaminion