Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix justified_checkpoint update #1250

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Fix justified_checkpoint update #1250

merged 4 commits into from
Jul 1, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jun 30, 2019 

    elif state.previous_justified_checkpoint.epoch > store.justified_checkpoint.epoch:
        store.justified_checkpoint = state.previous_justified_checkpoint

This condition seems never to be met since state.current_justified_checkpoint is always equal to or greater than state.previous_justified_checkpoint.

@hwwhww hwwhww changed the title Fork choice rule test Fix previous_justified_checkpoint update Jun 30, 2019
@hwwhww hwwhww added the milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet label Jul 1, 2019
@hwwhww hwwhww changed the title Fix previous_justified_checkpoint update Fix justified_checkpoint update Jul 1, 2019
@hwwhww hwwhww requested a review from djrtwo July 1, 2019 01:59
djrtwo
djrtwo approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@djrtwo djrtwo merged commit 350b9d7 into dev Jul 1, 2019
@djrtwo djrtwo deleted the fork_choice_rule_test branch July 1, 2019 03:03
@hwwhww hwwhww mentioned this pull request Jul 5, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet scope:fork-choice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @djrtwo